Addressed PR comments for notifications

Author: Croissant Le Doux

electron/ipc/register.ts

@@ -323,24 +323,27 @@ export function registerAllHandlers(win: BrowserWindow): void {
     cancelAskAboutCode(args.requestId);
   });
 
-  // --- Notifications ---
-  ipcMain.handle(IPC.ShowNotification, (_e, args) => {
-    assertString(args.title, 'title');
-    assertString(args.body, 'body');
-    assertString(args.threadId, 'threadId');
-    assertStringArray(args.taskIds, 'taskIds');
-    const notification = new Notification({
-      title: args.title,
-      body: args.body,
-    });
-    notification.on('click', () => {
-      if (!win.isDestroyed()) {
-        win.show();
-        win.focus();
-        win.webContents.send(IPC.NotificationClicked, { taskIds: args.taskIds });
-      }
-    });
-    notification.show();
+  // --- Notifications (fire-and-forget via ipcMain.on) ---
+  ipcMain.on(IPC.ShowNotification, (_e, args) => {
+    try {
+      assertString(args.title, 'title');
+      assertString(args.body, 'body');
+      assertStringArray(args.taskIds, 'taskIds');
+      const notification = new Notification({
+        title: args.title,
+        body: args.body,
+      });
+      notification.on('click', () => {
+        if (!win.isDestroyed()) {
+          win.show();
+          win.focus();
+          win.webContents.send(IPC.NotificationClicked, { taskIds: args.taskIds });
+        }
+      });
+      notification.show();
+    } catch (err) {
+      console.warn('ShowNotification failed:', err);
+    }
   });
 
   // --- Window management ---

electron/preload.cjs

@@ -94,6 +94,10 @@ contextBridge.exposeInMainWorld('electron', {
       if (!isAllowedChannel(channel)) throw new Error(`Blocked IPC channel: ${channel}`);
       return ipcRenderer.invoke(channel, ...args);
     },
+    send: (channel, ...args) => {
+      if (!isAllowedChannel(channel)) throw new Error(`Blocked IPC channel: ${channel}`);
+      ipcRenderer.send(channel, ...args);
+    },
     on: (channel, listener) => {
       if (!isAllowedChannel(channel)) throw new Error(`Blocked IPC channel: ${channel}`);
       const wrapped = (_event, ...eventArgs) => listener(...eventArgs);

package-lock.json

@@ -9,6 +9,7 @@ import {
   setThemePreset,
   setAutoTrustFolders,
   setShowPlans,
+  setDesktopNotificationsEnabled,
   setInactiveColumnOpacity,
   setEditorCommand,
 } from '../store/store';
@@ -177,6 +178,31 @@ export function SettingsDialog(props: SettingsDialogProps) {
             </span>
           </div>
         </label>
+        <label
+          style={{
+            display: 'flex',
+            'align-items': 'center',
+            gap: '10px',
+            cursor: 'pointer',
+            padding: '8px 12px',
+            'border-radius': '8px',
+            background: theme.bgInput,
+            border: `1px solid ${theme.border}`,
+          }}
+        >
+          <input
+            type="checkbox"
+            checked={store.desktopNotificationsEnabled}
+            onChange={(e) => setDesktopNotificationsEnabled(e.currentTarget.checked)}
+            style={{ 'accent-color': theme.accent, cursor: 'pointer' }}
+          />
+          <div style={{ display: 'flex', 'flex-direction': 'column', gap: '2px' }}>
+            <span style={{ 'font-size': '13px', color: theme.fg }}>Desktop notifications</span>
+            <span style={{ 'font-size': '11px', color: theme.fgSubtle }}>
+              Show native notifications when tasks finish or need attention
+            </span>
+          </div>
+        </label>
       </div>
 
       <div style={{ display: 'flex', 'flex-direction': 'column', gap: '10px' }}>

src/components/SettingsDialog.tsx

@@ -7,6 +7,7 @@ declare global {
     electron: {
       ipcRenderer: {
         invoke: (channel: string, ...args: unknown[]) => Promise<unknown>;
+        send: (channel: string, ...args: unknown[]) => void;
         on: (channel: string, listener: (...args: unknown[]) => void) => () => void;
         removeAllListeners: (channel: string) => void;
       };

src/lib/ipc.ts

@@ -41,6 +41,7 @@ export const [store, setStore] = createStore<AppStore>({
   windowState: null,
   autoTrustFolders: false,
   showPlans: true,
+  desktopNotificationsEnabled: false,
   inactiveColumnOpacity: 0.6,
   editorCommand: '',
   newTaskDropUrl: null,

src/store/core.ts

@@ -2,7 +2,6 @@ import { createEffect, onCleanup, type Accessor } from 'solid-js';
 import { store } from './store';
 import { getTaskDotStatus, type TaskDotStatus } from './taskStatus';
 import { setActiveTask } from './navigation';
-import { invoke } from '../lib/ipc';
 import { IPC } from '../../electron/ipc/channels';
 
 const DEBOUNCE_MS = 3_000;
@@ -34,12 +33,11 @@ export function startDesktopNotificationWatcher(windowFocused: Accessor<boolean>
         ready.length === 1
           ? `${taskName(taskIds[0])} is ready for review`
           : `${ready.length} tasks ready for review`;
-      invoke(IPC.ShowNotification, {
+      window.electron.ipcRenderer.send(IPC.ShowNotification, {
         title: 'Task Ready',
         body,
-        threadId: 'pc-task-ready',
         taskIds,
-      }).catch(console.warn);
+      });
     }
 
     if (waiting.length > 0) {
@@ -48,12 +46,11 @@ export function startDesktopNotificationWatcher(windowFocused: Accessor<boolean>
         waiting.length === 1
           ? `${taskName(taskIds[0])} needs your attention`
           : `${waiting.length} tasks need your attention`;
-      invoke(IPC.ShowNotification, {
+      window.electron.ipcRenderer.send(IPC.ShowNotification, {
         title: 'Task Waiting',
         body,
-        threadId: 'pc-task-waiting',
         taskIds,
-      }).catch(console.warn);
+      });
     }
   }
 
@@ -62,6 +59,7 @@ export function startDesktopNotificationWatcher(windowFocused: Accessor<boolean>
   }
 
   function scheduleBatch(notification: PendingNotification): void {
+    if (!store.desktopNotificationsEnabled) return;
     pending.push(notification);
     if (debounceTimer === undefined) {
       debounceTimer = setTimeout(flushNotifications, DEBOUNCE_MS);
@@ -111,9 +109,10 @@ export function startDesktopNotificationWatcher(windowFocused: Accessor<boolean>
   const offNotificationClicked = window.electron.ipcRenderer.on(
     IPC.NotificationClicked,
     (data: unknown) => {
-      const msg = data as { taskIds: string[] };
-      if (msg.taskIds?.length) {
-        setActiveTask(msg.taskIds[0]);
+      const msg = data as Record<string, unknown>;
+      const taskIds = Array.isArray(msg?.taskIds) ? (msg.taskIds as string[]) : [];
+      if (taskIds.length) {
+        setActiveTask(taskIds[0]);
       }
     },
   );

src/store/desktopNotifications.ts

@@ -40,6 +40,7 @@ export async function saveState(): Promise<void> {
     windowState: store.windowState ? { ...store.windowState } : undefined,
     autoTrustFolders: store.autoTrustFolders,
     showPlans: store.showPlans,
+    desktopNotificationsEnabled: store.desktopNotificationsEnabled,
     inactiveColumnOpacity: store.inactiveColumnOpacity,
     editorCommand: store.editorCommand || undefined,
     customAgents: store.customAgents.length > 0 ? [...store.customAgents] : undefined,
@@ -171,6 +172,7 @@ interface LegacyPersistedState {
   windowState?: unknown;
   autoTrustFolders?: unknown;
   showPlans?: unknown;
+  desktopNotificationsEnabled?: unknown;
   inactiveColumnOpacity?: unknown;
   editorCommand?: unknown;
   customAgents?: unknown;
@@ -269,6 +271,10 @@ export async function loadState(): Promise<void> {
       s.windowState = parsePersistedWindowState(raw.windowState);
       s.autoTrustFolders = typeof raw.autoTrustFolders === 'boolean' ? raw.autoTrustFolders : false;
       s.showPlans = typeof raw.showPlans === 'boolean' ? raw.showPlans : true;
+      s.desktopNotificationsEnabled =
+        typeof raw.desktopNotificationsEnabled === 'boolean'
+          ? raw.desktopNotificationsEnabled
+          : false;
       const rawOpacity = raw.inactiveColumnOpacity;
       s.inactiveColumnOpacity =
         typeof rawOpacity === 'number' &&